Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test model into repo instead of submodule #346

Merged
merged 11 commits into from
Jun 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "lexci_models"]
path = lexci_models
url = git@github.com:astro-informatics/lexci_models.git
2 changes: 1 addition & 1 deletion cpp/tests/cppflow_model.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ TEST_CASE("Cppflow Model"){
cppflow::tensor input_tensor = sopt::cppflowutils::convert_image_to_tensor(image, image_rows, image_cols);

// Read in model
cppflow::model model(std::string(sopt::notinstalled::models_directory() + "/DnCNN/snr_15_model.pb/"));
cppflow::model model(std::string(sopt::notinstalled::models_directory() + "/snr_15_model.pb/"));

// Run model on image
// TODO: Automatically detect the string parameters, see issue #320
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
Binary file not shown.
Binary file not shown.
Binary file not shown.
3 changes: 2 additions & 1 deletion cpp/tests/tf_inpainting.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ using Image = sopt::Image<Scalar>;
TEST_CASE("Inpainting"){
extern std::unique_ptr<std::mt19937_64> mersenne;
std::string const input = "cameraman256";
std::string const model_path = static_cast<std::string>(sopt::notinstalled::models_directory() + "/DnCNN/snr_15_model.pb/");

std::string const model_path = std::string(sopt::notinstalled::models_directory() + "/snr_15_model.pb/");

Image const image = sopt::notinstalled::read_standard_tiff(input);

Expand Down
4 changes: 2 additions & 2 deletions cpp/tools_for_tests/directories.in.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

namespace sopt::notinstalled {
//! Holds images and such
inline std::string data_directory() { return "@PROJECT_SOURCE_DIR@/images"; }
inline std::string data_directory() { return "@PROJECT_SOURCE_DIR@/cpp/tests/test_data"; }
//! Output artefacts from tests
inline std::string output_directory() { return "@PROJECT_BINARY_DIR@/outputs"; }
//! Tensorflow models
inline std::string models_directory() { return "@PROJECT_SOURCE_DIR@/lexci_models"; }
inline std::string models_directory() { return "@PROJECT_SOURCE_DIR@/cpp/tests/test_data"; }
} // namespace sopt::notinstalled
#endif
1 change: 0 additions & 1 deletion lexci_models
Submodule lexci_models deleted from eada5e