Concatenates nested namespaces (capability introduced in C++17 std) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnakumarg1984
force-pushed
the
kg/nested_namespaces
branch
from
c10f860
to
ad891db
Compare
SJaffa
reviewed
Jun 22, 2023
SJaffa
reviewed
Jun 22, 2023
SJaffa
reviewed
Jun 22, 2023
SJaffa
reviewed
Jun 22, 2023
SJaffa
reviewed
Jun 22, 2023
SJaffa
reviewed
Jun 22, 2023
krishnakumarg1984
force-pushed
the
kg/nested_namespaces
branch
from
965f479
to
7e8b2bb
Compare
…d in C++17 std) chore: restore doxygen comments that were accidentally deleted when concatenating namespaces
krishnakumarg1984
force-pushed
the
kg/nested_namespaces
branch
from
7e8b2bb
to
39d1ad3
Compare
SJaffa
approved these changes
Jun 23, 2023
krishnakumarg1984
added a commit
that referenced
this pull request
Jun 25, 2023
…d in C++17 std) (#368)
krishnakumarg1984
added a commit
that referenced
this pull request
Jul 21, 2023
* chore(safety,perf): partial set of fixes aiming at const correctness * chore: updates .gitignore with more ignore entries for C++/CMake * feat(modernise): concatenates nested namespaces (capability introduced in C++17 std) (#368) * feat(modernise): replaces c-style casts with static_cast< > (#374) --------- Co-authored-by: Tuomas Koskela <t.koskela@ucl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++17 introduced the ability to use concatenated nested namespaces instead of hierarchical nesting of namespace blocks. This is what C++20 & beyond standards uses right within the standard library.
References:
Closes #370.