Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial clean up of codebase #376

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Partial clean up of codebase #376

merged 3 commits into from
Jun 26, 2023

Conversation

krishnakumarg1984
Copy link
Collaborator

@krishnakumarg1984 krishnakumarg1984 commented Jun 22, 2023 •
edited
Loading

Clean up incorporates (amid others) the following:

  • removes duplicate header includes
  • adds missing header includes
  • adds closing namespace comments
  • removes unnecessary semicolons (null statements)

@krishnakumarg1984
chore(cleanup): cleans up codebase
cd676df 
Clean up incorporates (amid others) the following:
- removes duplicate header includes
- adds missing header includes
- adds Closing namespace comments
- removes unnecessary semicolons
tkoskela
tkoskela requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks good. I assume the standard library includes are all explicitly including things that are already being used in the code?

cpp/examples/primal_dual/inpainting.cc Show resolved Hide resolved
@krishnakumarg1984
Copy link
Collaborator Author

Cleanup looks good. I assume the standard library includes are all explicitly including things that are already being used in the code?

Yes.

@krishnakumarg1984 krishnakumarg1984 merged commit 63f4cfd into development Jun 26, 2023
@krishnakumarg1984 krishnakumarg1984 deleted the kg/misc_fixes branch June 26, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoskela tkoskela tkoskela approved these changes

@mmcleod89 mmcleod89 Awaiting requested review from mmcleod89

@SJaffa SJaffa Awaiting requested review from SJaffa

Assignees
No one assigned
Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishnakumarg1984 @tkoskela