Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cnp.import_array for numpy>=2 #75

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add cnp.import_array for numpy>=2 #75

merged 2 commits into from
Jul 1, 2024

Conversation

paddyroddy
Copy link
Collaborator

@paddyroddy paddyroddy commented Jun 17, 2024

@paddyroddy paddyroddy added the bug label Jun 17, 2024
@paddyroddy paddyroddy requested a review from mdavezac June 17, 2024 10:53
@paddyroddy paddyroddy self-assigned this Jun 17, 2024
@paddyroddy paddyroddy marked this pull request as ready for review June 17, 2024 10:55
@mdavezac
Copy link
Member

Perhaps the CI could be made to run with numpy>=2? That way it would be clearer that it works.

@paddyroddy
Copy link
Collaborator Author

Perhaps the CI could be made to run with numpy>=2? That way it would be clearer that it works.

Good idea, will do now

@paddyroddy
Copy link
Collaborator Author

@mdavezac done. Not sure if the tests here are exhaustive enough to know that this will fix downstream, though.

@jasonmcewen
Copy link
Contributor

jasonmcewen commented Jun 20, 2024

Are we sure we want to force numpy>=2? This could have downstream implications? @CosmoMatt what are you thoughts?

We might want to pause merging this until we've had a chance to also update other codes.

@jasonmcewen jasonmcewen self-requested a review June 20, 2024 10:13
@paddyroddy
Copy link
Collaborator Author

@jasonmcewen currently ssht is unusable if someone has numpy>=2 in their environment. So as a minimum, if you don't want to support v2 then numpy<2 should be pinned.

@jasonmcewen
Copy link
Contributor

Thanks @paddyroddy . Yes, we may need to pin to numpy 1 in the interium. We should support numpy 2 in the near future but we don't want to break a large number of our codes that use ssht before they've also been updated to support numpy 2.

@mdavezac
Copy link
Member

This is just in the ci, it doesn't affect users. Admittedly, it does depend on the test coverage... Though, if it used to fail at the import stage, then at least this change to the coffee and to the ci cover that.

@paddyroddy
Copy link
Collaborator Author

@mdavezac so is this safe to be merged? I don't have the power anyway

@mdavezac mdavezac merged commit 17a7f72 into main Jul 1, 2024
5 checks passed
@mdavezac mdavezac deleted the numpy branch July 1, 2024 10:06
@paddyroddy
Copy link
Collaborator Author

@mdavezac will there be a new python release/pre-release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support numpy>=2
3 participants