fix: exclude invalid dynamic params when generating alternates

astrolicious · May 1, 2024 · daa6ad2 · daa6ad2
1 parent f11c640
commit daa6ad2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -2,5 +2,8 @@
 	"editor.defaultFormatter": "biomejs.biome",
 	"[mdx]": {
 		"editor.defaultFormatter": "unifiedjs.vscode-mdx"
+	},
+	"[typescript]": {
+		"editor.defaultFormatter": "biomejs.biome"
 	}
 }
diff --git a/package/src/sitemap/generate-sitemap.ts b/package/src/sitemap/generate-sitemap.ts
@@ -61,24 +61,21 @@ export function generateSitemap(
 		}
 
 		const index = route.pages.indexOf(page);
-		const sitemapOptions = route.sitemapOptions[index];
-		if (!sitemapOptions) {
+		const sitemapOptions = route.sitemapOptions.filter(
+			(e) =>
+				e.dynamicParams &&
+				(Array.isArray(e.dynamicParams)
+					? e.dynamicParams
+					: Object.entries(e.dynamicParams)
+				).length > 0,
+		)[index];
+		if (!sitemapOptions || !sitemapOptions.dynamicParams) {
 			return [];
 		}
 
 		for (const equivalentRoute of equivalentRoutes) {
-			const options = normalizeDynamicParams(
-				sitemapOptions?.dynamicParams,
-			).find((e) => e.locale === equivalentRoute.route.locale);
-
-			// TODO: remove
-			console.dir(
-				{
-					page,
-					options,
-					sitemapOptions: normalizeDynamicParams(sitemapOptions?.dynamicParams),
-				},
-				{ depth: null },
+			const options = normalizeDynamicParams(sitemapOptions.dynamicParams).find(
+				(e) => e.locale === equivalentRoute.route.locale,
 			);
 
 			if (!options) {