Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hook, Operator and Trigger class #13

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Refactor Hook, Operator and Trigger class #13

merged 3 commits into from
Jun 21, 2024

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Jun 19, 2024

Hook

  • The get_connection call is moved to a property to improve encapsulation, ensuring that connections are fetched only when needed.

Operator

  • Unnecessary checks and methods have been removed to simplify the logic and reduce complexity.
  • Methods that aren't used widely have been converted to private methods (_method_name) to signify their internal use

Trigger

  • Custom timeout handling and related loops have been removed to streamline the class and adhere to simpler, more standardized tiggerer timeout mechanisms.
  • Unused methods are removed, and others are privatized to improve code maintainability and reduce surface area for potential bugs.

@pankajastro pankajastro merged commit f013951 into main Jun 21, 2024
15 checks passed
@pankajastro pankajastro deleted the code_cleanup branch June 21, 2024 16:17
@pankajastro pankajastro added this to the 1.0.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants