Use an Airflow config to manage provider configuration #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana
changed the title
venkatajagannath
approved these changes
Jun 28, 2024
tatiana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the provider used standard operating system environment variables to receive user configuration.
This PR changes these to Airflow config, which already gracefully handles booleans and supports setting the configuration via environment variables and via
airflow.cfg.This PR introduces these changes:
ANYSCALE__AIRFLOW_TELEMETRY_ENABLEDbyAIRFLOW__ANYSCALE__CLI_TOKEN(or equivalentairflow.cfg)AIRFLOW__ANYSCALE__CLI_TOKEN(or equivalentairflow.cfg) as an alternative toANYSCALE_CLI_TOKENNote: the following is discussed in a separate PR (#42), so I removed changing the default value for telemetry from the current PR.
The current documentation needs to provide more information about the telemetry and data collection, which is a crucial aspect that needs to be addressed.Until the following questions are addressed, I believe it should be disabled by default:* How does enabling telemetry help users?* Where is the data being sent?* What data is being collected?* How is the data being used?