Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the chatroom server in an executable binary 56 #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CptOrange16
Copy link

2 binaries were created: one for windows and one for linux (on Ubuntu 18.04).
They are both running and working as expected.
To run use (for example):

On windows: binary.exe -s 6969-c 9696-4
On Linux: ./binary -s 6969-c 9696-4

There are also 2 .spec files used for building both binaries because even though they have my system path they may be useful to see the configurations needed to generate a binary in the future.

This closes #56

@gridhead
Copy link
Member

gridhead commented Oct 3, 2020

Cool. Allow me some time to review your pull request. Feel free to move on to other issues that you would want to work on.

@gridhead gridhead self-requested a review October 3, 2020 04:27
@gridhead gridhead added enhancement New feature or request hacktoberfest Contribute to the notion of open-source this October! labels Oct 3, 2020
@gridhead gridhead added hacktoberfest-accepted Thank you for your contributions and removed enhancement New feature or request hacktoberfest Contribute to the notion of open-source this October! labels Oct 15, 2020
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved the contributions you made and have added hacktoberfest-accepted label to the PR. Will merge it shortly.

@amaank404
Copy link
Contributor

Hello @CptOrange16, just wanted to know how to add the data (folder and files) to it using pyinstaller command line.
Also, you might want to remake the executable of the sanctuary.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Thank you for your contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package the chatroom server in an executable binary
4 participants