Skip to content

Commit

Permalink
minor readme update + jeffs nits
Browse files Browse the repository at this point in the history
  • Loading branch information
johnstonematt committed Nov 5, 2024
1 parent 95657c9 commit d2c2ff2
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ The exporter is configured via the following command line arguments:
* Configuring `-monitor-block-sizes` with many `-nodekey`'s can potentially strain the node - every block produced
by a configured `-nodekey` is fetched, and a typical block can be as large as 5MB.

If you want verbose logs, specify `-v=<num>`. Higher verbosity means more debug output. For most users, the default
verbosity level is fine. If you want detailed log output for missed blocks, run with `-v=1`.

## Metrics
### Overview

Expand Down
8 changes: 4 additions & 4 deletions cmd/solana-exporter/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,19 @@ func NewExporterConfig(
)
if lightMode {
if comprehensiveSlotTracking {
return nil, fmt.Errorf("'-light-mode' is imcompatible with `-comprehensive-slot-tracking`")
return nil, fmt.Errorf("'-light-mode' is incompatible with `-comprehensive-slot-tracking`")
}

if monitorBlockSizes {
return nil, fmt.Errorf("'-light-mode' is imcompatible with `-monitor-block-sizes`")
return nil, fmt.Errorf("'-light-mode' is incompatible with `-monitor-block-sizes`")
}

if len(nodeKeys) > 0 {
return nil, fmt.Errorf("'-light-mode' is imcompatible with `-nodekey`")
return nil, fmt.Errorf("'-light-mode' is incompatible with `-nodekey`")
}

if len(balanceAddresses) > 0 {
return nil, fmt.Errorf("'-light-mode' is imcompatible with `-balance-addresses`")
return nil, fmt.Errorf("'-light-mode' is incompatible with `-balance-addresses`")
}
}

Expand Down
1 change: 1 addition & 0 deletions cmd/solana-exporter/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,5 @@ func TestCountVoteTransactions(t *testing.T) {
assert.NoError(t, err)
// https://explorer.solana.com/block/297609329
assert.Equal(t, 1048, voteCount)
assert.Equal(t, 446, len(block.Transactions)-voteCount)
}
1 change: 1 addition & 0 deletions pkg/rpc/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
)

func newMethodTester(t *testing.T, method string, result any) (*MockServer, *Client) {
t.Helper()
return NewMockClient(t, map[string]any{method: result}, nil, nil, nil, nil)
}

Expand Down

0 comments on commit d2c2ff2

Please sign in to comment.