Added support for getHealth method, introducing solana_is_healthy, so… #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEJeff
reviewed
Oct 3, 2024
There was a problem hiding this comment.
getHelth
We'd like to get a few refactors (especially #34) in and then accept this. It might require a few small updates stylistically that @johnstonematt is working on.
Merged
|
Thinking here, wouldn't it make more sense to add the health-check to the |
…lana_num_slots_behind (after refactoring)
GranderStark
force-pushed
the
feature/add_get_health_num_slots_behind
branch
from
ba35a23 to
0a0782b
Compare
johnstonematt
merged commit 2db8436
into
asymmetric-research:get-health
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lana_num_slots_behind
Added support for getHealth rpc method. Introduced solana_is_healthy and solana_num_slots_behind metrics
TBD: