Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix workflow main/master bug #35

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix workflow main/master bug #35

merged 1 commit into from
Oct 7, 2024

Conversation

johnstonematt
Copy link
Contributor

@johnstonematt johnstonematt commented Oct 6, 2024 •
edited
Loading

Added a workflow to check that the code builds, and fixed the main/master naming bug in existing workflows

SEJeff
SEJeff approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is fully necessary. If you run go test, it inherently builds the software. If the build fails, the tests won't built or run.

The fixes are sensible however.

@johnstonematt johnstonematt changed the title added go build workflow fix workflow main/master bug Oct 7, 2024
@johnstonematt johnstonematt merged commit 01db171 into master Oct 7, 2024
2 checks passed
@johnstonematt johnstonematt deleted the build-test-workflow branch October 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEJeff SEJeff SEJeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstonematt @SEJeff