Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored config #43

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Refactored config #43

merged 3 commits into from
Oct 17, 2024

Conversation

johnstonematt
Copy link
Contributor

@johnstonematt johnstonematt commented Oct 14, 2024

Config Simplification

  • Instead of separately configuring inflation-reward-addresses, fee-reward-addresses, balance-addresses, and leader-slot-addresses, you now configure balance-addresses, nodekeys and comprehensive-slot-tracking.
  • Vote accounts are inferred from the nodekeys using the getVoteAccounts RPC, and then we have:
    • inflation-reward-addresses -> votekeys
    • fee-reward-addresses -> nodekeys
    • balance-addresses -> votekeys + nodekeys + balance-addresses (i.e., balance-addresses is now used to configure extra accounts you want to track balances for, in addition to the configured validator accounts)
  • Removed the votePubkey config option.

Label Standardisation

Previously, vote accounts were referred to under the rather generically named pubkey label, which has now been replaced with votekey. Additionally, the labels are all explicitly written as constants.

NOTE: If we move forward with this one, it will be a breaking change that will affect the way metrics are stored in Prometheus.

Other changes

  • changed http_timeout flag to http-timeout
  • Added default value for rpc-url (also changed rpcURI to rpc-url

@johnstonematt johnstonematt marked this pull request as ready for review October 14, 2024 16:08
@johnstonematt johnstonematt requested a review from SEJeff October 14, 2024 16:08

StateCurrent = "current"
StateDelinquent = "delinquent"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@johnstonematt johnstonematt merged commit db4d606 into master Oct 17, 2024
2 checks passed
@johnstonematt johnstonematt deleted the config branch October 17, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants