pull/report 'identity' for the node #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEJeff
reviewed
Dec 26, 2024
There was a problem hiding this comment.
The irony here is that similar-ish functionality was added in #55 to add identity labels to many of the metrics, but was removed in #64. It was decided the identity label was not necessary for most of these metrics.
How would you envision it being used exactly? You'd know which server the identity resided on by the instance key? For our internal usage of this exporter, we have the scraper add a hostname label to all metrics of all exporters so we can query all metrics for a single host.
|
So for our use case, this is specifically for tracking when failover
occurs.
We follow a pretty common guide for implementing primary/backup servers:
https://pumpkins-pool.gitbook.io/pumpkins-pool
Essentially both servers have a shared (voting) identity, and each has an
individual backup identity. The primary (voting) server will run the
shared voting identity, and the backup server will run using its individual
backup identity. During failover, the primary identity gets changed to use
the backup identity, and then the backup is changed to use the voting
identity.
I'd like to have a time-series showing which server is actively running the
voting identity, so on a dashboard I can see when failovers occurred.
…On Thu, Dec 26, 2024, 2:20 PM Jeff Schroeder ***@***.***> wrote:
***@***.**** commented on this pull request.
The irony here is that similar-ish functionality was added in #55
<#55> to add
identity labels to many of the metrics, but was removed in #64
<#64>. It was
decided the identity label was not necessary for most of these metrics.
How would you envision it being used exactly? You'd know which server the
identity resided on by the instance key? For our internal usage of this
exporter, we have the scraper add a hostname label to all metrics of all
exporters so we can query all metrics for a single host.
—
Reply to this email directly, view it on GitHub
<#83 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM3ZRSESUDYYTQYSPZGDIMT2HRJGXAVCNFSM6AAAAABUFATMESVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRTGQZTGNZXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@impactdni2 please update the unit tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a primary/failover setup, this allows tracking which server is running each identity (voting vs standby keys).