Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proxy support in commands/generate folder #1622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IITI-tushar
Copy link

Description
solves issue #1621
Reference:https://www.zenrows.com/blog/node-fetch-proxy#how-to-use-proxy-with-node-fetch of the implementation flow of the proxy

Related issue(s)
Resolves #1621

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 6f00471

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AayushSaini101
Copy link
Collaborator

@IITI-tushar Kindly add some test cases to verify the changes thanks

@IITI-tushar
Copy link
Author

Sure... @AayushSaini101

@IITI-tushar IITI-tushar force-pushed the Add-proxy-support-for-the-generate-from-template-command branch from 7639803 to 6f00471 Compare January 17, 2025 09:10
@AayushSaini101
Copy link
Collaborator

@IITI-tushar Please check some test cases are not passing, please check
Error: src/commands/generate/models.ts(30,9): error TS7034: Variable 'proxyAgent' implicitly has type 'any' in some locations where its type cannot be determined.
Error: src/commands/generate/models.ts(47,83): error TS7005: Variable 'proxyAgent' implicitly has an 'any' type.

@AayushSaini101 AayushSaini101 self-requested a review January 17, 2025 18:43
@@ -29,6 +43,9 @@ export default class Models extends Command {
output = parsedArgs.output;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check here @IITI-tushar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

[ Feature ] Add proxy support for the generate from template command
2 participants