Skip to content

docs: fix https: Remove styling wrappers from TSC_VOTING_OVERVIEW to property render it on the website #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: fix https: Remove styling wrappers from TSC_VOTING_OVERVIEW to property render it on the website #2152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c772092
Removed span tags from markdownTable.js for deployment fix
Pratham-Saini2703 Nov 17, 2025
6772bbd
Merge branch 'master' into master
asyncapi-bot Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/scripts/vote_tracker/markdownTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ function renderVoteIcon(value) {
Abstain: "👀",
"Not participated": "🔕",
};
return `<span style="position: relative; cursor: pointer;" title="${value}">${icons[value] || value}</span>`;
return `${icons[value] || value}`;

}

/**
Expand Down Expand Up @@ -47,7 +48,7 @@ function renderHeaderCell(key, titles, orgName, repoName) {
}

const tooltip = titles[key] || key;
return `<span style="position: relative; cursor: pointer;" title="${tooltip}">${key}</span>`;
return `${key}`;
Comment on lines 49 to +51
Copy link

@coderabbitai coderabbitai bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Remove unused variable.

The tooltip variable is calculated but never used after removing the HTML span wrapping. Consider removing it or the entire titles parameter if tooltips are no longer needed.

Apply this diff:

- const tooltip = titles[key] || key;
  return `${key}`;

Alternatively, if the titles parameter is no longer needed at all, you could simplify the entire function signature. However, this would require updating all call sites, so removing just the unused variable is safer.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const tooltip = titles[key] || key;
return `<span style="position: relative; cursor: pointer;" title="${tooltip}">${key}</span>`;
return `${key}`;
return `${key}`;
🤖 Prompt for AI Agents 
.github/scripts/vote_tracker/markdownTable.js around lines 50-51: the variable
`tooltip` is computed but never used; remove the unused `const tooltip =
titles[key] || key;` line (or if you prefer a bigger change, remove the `titles`
parameter from the function and update call sites, but safer here is to simply
delete the unused variable) and run eslint/TypeScript checks to ensure no
unused-variable warnings remain.

}

/**
Expand Down