Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the method of importing the parser #1045

Merged
merged 12 commits into from
Aug 2, 2024

Conversation

ayushnau
Copy link
Contributor

@ayushnau ayushnau commented Aug 1, 2024

Changes Added.

1. updated the way the nunjucks filter was importing the generator. 

Related issue(s)

Related to: #963

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: 5a237b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/multi-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ayushnau
Copy link
Contributor Author

ayushnau commented Aug 1, 2024

@smoya
Fixed this.

image
image

In your example the error is coming due to asyncapi validation other wise the multiparser package is working fine.

I have used this package for testing. @ayushnautiyal706020/multi-parser
Also pushed this code here if you want to check https://github.com/ayushnau/asyncapi-parser-example

@ayushnau ayushnau changed the title feat: updated the way the nunjucks filter was importing the generator. feat: updated the method of importing the generator. Aug 1, 2024
@aeworxet
Copy link
Contributor

aeworxet commented Aug 1, 2024

@asyncapi/bounty_team

@smoya
Copy link
Member

smoya commented Aug 2, 2024

I don't get why we need this change. Can you please elaborate on that?

@smoya
Copy link
Member

smoya commented Aug 2, 2024

@ayushnau

In your example the error is coming due to asyncapi validation other wise the multiparser package is working fine.

Attaching two screenshots running a simple example both with @smoya/multi-parser package and then with @asyncapi/multi-parser one. See the error on the second.

Using @smoya/multi-parser

Code_0voe7Odx@2x

Using @asyncapi/multi-parser

Code_EsUr0mJD@2x

@ayushnau
Copy link
Contributor Author

ayushnau commented Aug 2, 2024

I don't get why we need this change. Can you please elaborate on that?

Before I was using parserv3: file::../parser to import the parser in multiparser. but doing this way was creating problem in production build. of the multiparser. It turns out that in turborepo for importing internal dependency we need to use
@asyncapi/parser : "*" this only works if we are using the name which is in the package.json of the package. So we need to use @asyncapi/parser instead of parserv3

@ayushnau
Copy link
Contributor Author

ayushnau commented Aug 2, 2024

@ayushnau

In your example the error is coming due to asyncapi validation other wise the multiparser package is working fine.

Attaching two screenshots running a simple example both with @smoya/multi-parser package and then with @asyncapi/multi-parser one. See the error on the second.

Using @smoya/multi-parser

Code_0voe7Odx@2x

Using @asyncapi/multi-parser

Code_EsUr0mJD@2x

yes I am aware of this. Merging this pr will fix this.

@smoya
Copy link
Member

smoya commented Aug 2, 2024

The prefix title of the pr should be fix.

"@asyncapi/multi-parser": patch
---

Adding the Way the generator is imported in Nunjucks filter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the message so it reflects what it fixes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@ayushnau ayushnau changed the title feat: updated the method of importing the generator. fix: updated the method of importing the generator. Aug 2, 2024
@ayushnau ayushnau changed the title fix: updated the method of importing the generator. fix: updated the method of importing the parser. Aug 2, 2024
Copy link

sonarcloud bot commented Aug 2, 2024

@ayushnau
Copy link
Contributor Author

ayushnau commented Aug 2, 2024

/rtm

@smoya
Copy link
Member

smoya commented Aug 2, 2024

/rtm

1 similar comment
@smoya
Copy link
Member

smoya commented Aug 2, 2024

/rtm

@smoya smoya changed the title fix: updated the method of importing the parser. fix: updated the method of importing the parser Aug 2, 2024
@smoya
Copy link
Member

smoya commented Aug 2, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 657fa8e into asyncapi:master Aug 2, 2024
15 checks passed
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants