Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update streetlights-kafka.yml #912

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Conversation

eelcofolkertsma
Copy link
Contributor

**Description
Restore the common mark up for description: in info: and alter opening line to match OpenAPI (was "description: >", is "description: |-")

Related issue(s)
Resolves #906

Snapshot of original file and rendering
image

Snapshot of updated file and rendering
image

Restore the common mark up for description: in info: and alter opening line to match OpenAPI (description: |-)
Copy link

changeset-bot bot commented Dec 28, 2023

⚠️ No Changeset found

Latest commit: a1e5da6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit a1e5da6
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/6596b03d6151f70008ce0a66
😎 Deploy Preview https://deploy-preview-912--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit a1e5da6
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/6596b03d41e1520008494282
😎 Deploy Preview https://deploy-preview-912--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Description: updated for correct commonmark rendering
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MarkDown indent fixed for description:
Fixed MarkDown flag in description: ("|-" instead of ">")
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor Author

@eelcofolkertsma eelcofolkertsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR should be clean now

  • all master changes synced
  • all examples and default reviewed on rendering and found OK

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KhudaDad414
Copy link
Member

/rtm

@KhudaDad414
Copy link
Member

Thanks for the contribution @eelcofolkertsma 🙇

@asyncapi-bot asyncapi-bot merged commit a35393b into asyncapi:master Jan 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studio fails to render CommonMarkings
3 participants