-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update streetlights-kafka.yml #912
Conversation
Restore the common mark up for description: in info: and alter opening line to match OpenAPI (description: |-)
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Description: updated for correct commonmark rendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MarkDown indent fixed for description:
Fixed MarkDown flag in description: ("|-" instead of ">")
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR should be clean now
- all master changes synced
- all examples and default reviewed on rendering and found OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
Thanks for the contribution @eelcofolkertsma 🙇 |
**Description
Restore the common mark up for description: in info: and alter opening line to match OpenAPI (was "description: >", is "description: |-")
Related issue(s)
Resolves #906
Snapshot of original file and rendering
![image](https://private-user-images.githubusercontent.com/71253997/293222874-144bc7b7-44c8-4948-babe-32a26e90b23e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Njg1OTIsIm5iZiI6MTczOTU2ODI5MiwicGF0aCI6Ii83MTI1Mzk5Ny8yOTMyMjI4NzQtMTQ0YmM3YjctNDRjOC00OTQ4LWJhYmUtMzJhMjZlOTBiMjNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIxMjQ1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5YTQzZDkzNmI1YjIyMDVhYWMwNmQ5MTYwNWNlYmRlNmMwYTAwZGZiMzg4YjU1YTZkYjE3YzVkNGVlYjZmY2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QqDXRK0zXUVwD5TzWJ60iuTYEQ1rOL4jqBb9bc4H3Xg)
Snapshot of updated file and rendering
![image](https://private-user-images.githubusercontent.com/71253997/293222989-e4180ad3-64b1-4e54-bb43-385f515297f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Njg1OTIsIm5iZiI6MTczOTU2ODI5MiwicGF0aCI6Ii83MTI1Mzk5Ny8yOTMyMjI5ODktZTQxODBhZDMtNjRiMS00ZTU0LWJiNDMtMzg1ZjUxNTI5N2Y0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIxMjQ1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4M2FiYzNlYmJjZTlmNGYwNWRiMmU1MmIxM2NhNTYyYjk5NGU5NjlhYTZmODQ3OTVhOGVhYTJlZGFmMGU5NWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.s0hnS_zbVWLDRj76-bQhPaDZvO6vBfQLAGmKf_94HBE)