-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct unsigned long handling #161
Conversation
- Add code comments to explain how to handle the length encoded integer. - Correct LargeFieldReader.readSlice() method, it should use the length as an unsigned long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Hello @mirromutth, Would you be interested in rejoining the project? Your expertise is invaluable. If you find the time and inclination to participate once again, your insights and guidance would be highly appreciated. Thank you for considering this, and I look forward to hearing from you. |
Hello @jchrys, Thank you for your kind words. I appreciate your message and the kind invitation to rejoin the project. Yes, I think I can do something to this project. While I may not consider myself an expert, I am interested in making some contributions to the project. Thank you for considering my participation, please let me know if there is anything I need to note. Best Regards, |
Thanks for your reply! 🎉 |
Motivation: Length-encoded integers should be handled correctly, especially those larger than `Long.MAX_VALUE`. See also #39. Modification: - Add code comments to explain how to handle the length encoded integer. - Correct `LargeFieldReader.readSlice()` method, it should use the length as an unsigned long. Result: - `LargeFieldReader.readSlice()` should now work correctly for fields those size is greater than 2<sup>63</sup>-1
Motivation: Length-encoded integers should be handled correctly, especially those larger than `Long.MAX_VALUE`. See also #39. Modification: - Add code comments to explain how to handle the length encoded integer. - Correct `LargeFieldReader.readSlice()` method, it should use the length as an unsigned long. Result: - `LargeFieldReader.readSlice()` should now work correctly for fields those size is greater than 2<sup>63</sup>-1
Motivation:
Length-encoded integers should be handled correctly, especially those larger than
Long.MAX_VALUE
. See also #39.Modification:
LargeFieldReader.readSlice()
method, it should use the length as an unsigned long.Result:
LargeFieldReader.readSlice()
should now work correctly for fields those size is greater than 263-1