Fixed NPE with SslMode.TUNNEL Usage
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @mirromutth @JohnNiang |
jchrys
force-pushed
the
1x-fix-npe-tunnel
branch
from
ad9fc41 to
56eb874
Compare
|
Planning to release version 1.1.1 once this issue is resolved. |
jchrys
force-pushed
the
1x-fix-npe-tunnel
branch
2 times, most recently
from
684e95c to
9980c67
Compare
Motivation: A NPE was identified when utilizing `SslMode.TUNNEL`. The issue arises when `ConnectionContext#isMariaDb` is invoked from `SslBridgeHandler#isTls13Enabled`, leading to an NPE due to the `ConnectionContext` not being initialized at that time. Modification: Do not invoke `ConnectionContext#isMariaDb` when it is not initialized. Result: This change addresses the NPE issue, ensuring stability when `SslMode.TUNNEL` is selected. resolves GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#1828
jchrys
force-pushed
the
1x-fix-npe-tunnel
branch
from
9980c67 to
666cc3e
Compare
mirromutth
requested changes
Feb 8, 2024
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mirro Mutth <mirromutth@gmail.com> Signed-off-by: jchrys <jchrys@me.com>
mirromutth
approved these changes
Feb 8, 2024
src/test/java/io/asyncer/r2dbc/mysql/SslTunnelIntegrationTest.java
Outdated
Show resolved
Hide resolved
JohnNiang
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A NPE was identified when utilizing
SslMode.TUNNEL. The issue arises whenConnectionContext#isMariaDbis invoked fromSslBridgeHandler#isTls13Enabled, leading to an NPE due to theConnectionContextnot being initialized at that time.Modification:
Do not invoke
ConnectionContext#isMariaDbwhen it is not initialized.Result:
This change addresses the NPE issue, ensuring stability when
SslMode.TUNNELis selected. It resolves the problem reported in GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#1828