fix: remove basePath from llms.txt URL generation to avoid duplicated paths#139
Merged
fix: remove basePath from llms.txt URL generation to avoid duplicated paths#139
Conversation
… paths SITE_URL already includes the base path (e.g., https://aszenz.github.io/data-explorer), so appending basePath again caused URLs like /data-explorer/data-explorer/. https://claude.ai/code/session_013EEswtBtNGKgqVDj7GPw6j
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the llms.txt URL generation where paths were being duplicated (e.g., /data-explorer/data-explorer/) because the basePath was being appended to SITE_URL which already contained the full base URL including the path.
Changes:
- Removed
basePathparameter fromGeneratorOptionsinterface and all related function signatures - Updated URL generation logic to use
siteUrldirectly instead of concatenatingsiteUrlwithbasePath - Removed the
basePath: config.baseargument from the plugin's call togenerateLlmsTxtContent
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/llms-txt/generator.ts |
Removed basePath from GeneratorOptions interface and updated generateHeader, generateOverview, and generateModelsSection functions to use siteUrl directly |
plugins/vite-plugin-llms-txt.ts |
Removed basePath: config.base from the generateLlmsTxtContent function call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SITE_URL already includes the base path (e.g., https://aszenz.github.io/data-explorer),
so appending basePath again caused URLs like /data-explorer/data-explorer/.
https://claude.ai/code/session_013EEswtBtNGKgqVDj7GPw6j