Skip to content

Perbaikan duplikasi data config #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2023
Merged

Perbaikan duplikasi data config #583

merged 3 commits into from
Dec 11, 2023

Conversation

totoprayogo1916
Copy link
Contributor

Deskripsi
Duplikasi pemanggilan config.
Sebelumnya terdapat $data['desa'] dan $data['data_config'],
Karena menggunakan fungsi yang sama, maka $data['data_config'] dihapus.

@totoprayogo1916 totoprayogo1916 added peningkatan Fitur baru, permintaan atau upgrade perbaikan Perbaikan masalah pada bug yang ditemukan labels Dec 11, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2023
View reviewed changes
donjo-app/controllers/First.php
@@ -57,8 +58,11 @@

public function index($p = 1)
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '61', column '23').
donjo-app/controllers/First.php
@@ -90,11 +93,14 @@

public function mandiri($p = 1, $m = 0)
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '96', column '23').
donjo-app/controllers/First.php
@@ -129,10 +134,12 @@

public function artikel($id = '', $p = 1)
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '137', column '29').
donjo-app/controllers/First.php
view('layouts/artikel.tpl.php', $data);
}

public function arsip($p = 1)
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '166', column '31').
donjo-app/controllers/First.php

view('layouts/arsip.tpl.php', $data);
}

public function gallery($p = 1)
{
$data['p'] = $p;
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '190', column '23').
donjo-app/controllers/First.php

view('layouts/stat.tpl.php', $data);
}

public function data_analisis($stat = '', $sb = 0, $per = 0)
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '312', column '23').
donjo-app/controllers/First.php
view('layouts/analisis.tpl.php', $data);
}

public function wilayah()
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '339', column '23').
donjo-app/controllers/First.php
view('layouts/stat.tpl.php', $data);
}

public function statistik_k($tipex = 0)
{
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '365', column '23').
donjo-app/controllers/First.php
$data['sosmed'] = $this->first_artikel_m->list_sosmed();
$data['stat'] = $this->first_penduduk_m->list_data(4);
$data['data_config'] = $this->config_model->get_data();
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '390', column '34').
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2023
View reviewed changes
donjo-app/controllers/First.php

view('layouts/main.tpl.php', $data);
}

public function kategori($kat = 0, $p = 0)
{
$data['p'] = $p;
$data['desa'] = $this->config_model->get_data();
$config = new Config();

Check warning

Code scanning / PHPMD

Clean Code Rules: MissingImport

Missing class import via use statement (line '407', column '23').
@totoprayogo1916 totoprayogo1916 merged commit 8495f71 into 4.5.x Dec 11, 2023
@totoprayogo1916 totoprayogo1916 deleted the first branch December 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
peningkatan Fitur baru, permintaan atau upgrade perbaikan Perbaikan masalah pada bug yang ditemukan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@totoprayogo1916