Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use cmake modules for PhysFS #30

Closed
wants to merge 3 commits into from
Closed

[WIP] Use cmake modules for PhysFS #30

wants to merge 3 commits into from

Conversation

frabert
Copy link
Collaborator

@frabert frabert commented Feb 4, 2019

This PR should solve issue REGoth-project/REGoth#369 by removing the need to keep our git clone of the PhysFS mercurial repo.

Instead, it searches for a preinstalled copy of PhysFS in the system.
Issues with this method:

  • Windows doesn't have a central source for packages, PhysFS will need to be compiled and installed manually
  • Ubuntu before version 18.04 ships an obsolete version of PhysFS, so it will need to be manually compiled and installed, too

Both of the issues can be solved by distributing a script with REGoth which automatically downloads and installs the dependencies in a subdirectory, as discussed previously with @markusobi

@ataulien
Copy link
Owner

Done in #33.

@ataulien ataulien closed this Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants