Add pdf2htmlEX support #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwgmeligmeyling
commented
May 12, 2024
| @@ -15,6 +16,10 @@ export function createIntegration(annotator: Annotator): Integration { | |||
| return new PDFIntegration(annotator); | |||
| } | |||
|
|
|||
| if (isPdf2htmlEX()) { | |||
There was a problem hiding this comment.
Ideally I would pass an integration through the hypothesis config object, but this how its currently done for the existing PDF.js integration 🤷🏻♂️
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
|
|
||
| let page = this._pdfViewer.pages.find(page => { | ||
| let xpath = xpathFromNode(page.page, root); | ||
| return range?.startContainer.startsWith(xpath) |
There was a problem hiding this comment.
Couldn't find a better way than an xpath prefix comparison to find the page.
It also means that we're basically only relying on RangeSelector whereas the other selectors are deemed more performant or robust. Luckily, the DOM of the pdf2HtmlEx output is stable.
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
commented
May 12, 2024
jwgmeligmeyling
force-pushed
the
pdf2htmlex
branch
6 times, most recently
from
bdba276 to
ea9d000
Compare
jwgmeligmeyling
force-pushed
the
pdf2htmlex
branch
from
ea9d000 to
5b5b434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A start with pdf2htmlEX support for Hypothes.is
Screenshots
Collapsed
Side-by-side