Skip to content

feat: insert markdown link with ctrl/cmd+k when inside block#1879

Open
jefftangx wants to merge 3 commits intoathensresearch:mainfrom
jefftangx:insert-markdown-link
Open

feat: insert markdown link with ctrl/cmd+k when inside block#1879
jefftangx wants to merge 3 commits intoathensresearch:mainfrom
jefftangx:insert-markdown-link

Conversation

@jefftangx
Copy link
Copy Markdown
Collaborator

@jefftangx jefftangx commented Nov 27, 2021

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/5AqrQqU1ymEqkk1SHDx1UtGqbLVU
✅ Preview: https://athens-git-fork-tangjeff0-insert-markdown-link-athens-research.vercel.app

@jefftangx jefftangx changed the title feat: insert markdown link with cmd+k feat: insert markdown link with ctrl/cmd+k when inside block Nov 27, 2021
@neotyk
Copy link
Copy Markdown
Collaborator

neotyk commented Dec 8, 2021

It's conflicting with Athena invocation.
Can we do some other shortcut for it?

@lukaskawerau
Copy link
Copy Markdown

It's conflicting with Athena invocation.
Can we do some other shortcut for it?

Cmd-k is the universal shortcut for linking things, including here on Github. Imo Athens should conform to that convention. One option would be that the trigger does different things when a block is focused/you're typing inside a block and when no block is focused.

@jefftangx
Copy link
Copy Markdown
Collaborator Author

jefftangx commented Dec 9, 2021

Happy medium solution:

  • cmd-p for always-whenever Athena, in any context
  • cmd-k for inserting links when cursor is in a block

Notion does this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants