Skip to content

Commit

Permalink
add todo comments for html unescaped strings
Browse files Browse the repository at this point in the history
  • Loading branch information
mvorisek committed Mar 6, 2025
1 parent 105dd78 commit 52e6ac9
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 12 deletions.
1 change: 1 addition & 0 deletions js/src/JqueryPlugin/ConfirmPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export default class AtkConfirmPlugin extends AbstractPlugin {
}

getDialogHtml(message) {
// TODO: HTML escape
return `
<div class=" content">${message}</div>
<div class="actions">
Expand Down
1 change: 1 addition & 0 deletions js/src/JqueryPlugin/CreateModalPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export default class AtkCreateModalPlugin extends AbstractPlugin {
}

getDialogHtml(title) {
// TODO: HTML escape
return `<i class="close icon"></i>
` + (title ? `<div class="${this.settings.headerClass}">${title}</div>
` : '') + `<div class="${this.settings.contentClass} content atk-dialog-content">
Expand Down
2 changes: 1 addition & 1 deletion js/src/JqueryPlugin/JsSortablePlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default class AtkJsSortablePlugin extends AbstractPlugin {
}

injectStyles(style) {
$('head').append('<style>' + style + '</style>');
$('head').append('<style>' + style + '</style>'); // TODO: prevent HTML injection
}
}

Expand Down
7 changes: 4 additions & 3 deletions js/src/Service/apiService.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,13 @@ class ApiService {
m.data('needRemove', true).modal().modal('show');
}

getErrorHtml(titleHtml, messageHtml) {
getErrorHtml(title, message) {
// TODO: HTML escape
return `<div class="ui negative icon message" style="margin: 0px;">
<i class="warning sign icon"></i>
<div class="content">
<div class="header">${titleHtml}</div>
<div>${messageHtml}</div>
<div class="header">${title}</div>
<div>${message}</div>
</div>
</div>`;
}
Expand Down
2 changes: 1 addition & 1 deletion js/src/Service/modalService.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class ModalService {

getLoaderHtml(loaderText) {
return '<div class="ui active inverted dimmer">'
+ '<div class="ui text loader">' + loaderText + '</div>'
+ '<div class="ui text loader">' + loaderText + '</div>' // TODO: HTML escape
+ '</div>';
}
}
Expand Down
14 changes: 9 additions & 5 deletions public/js/atkjs-ui.js
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,7 @@ class AtkConfirmPlugin extends _AbstractPlugin__WEBPACK_IMPORTED_MODULE_1__["def
$m.data('needRemove', true).modal(options).modal('show');
}
getDialogHtml(message) {
// TODO: HTML escape
return `
<div class=" content">${message}</div>
<div class="actions">
Expand Down Expand Up @@ -1285,6 +1286,7 @@ class AtkCreateModalPlugin extends _AbstractPlugin__WEBPACK_IMPORTED_MODULE_1__[
$m.addClass(this.settings.modalCss);
}
getDialogHtml(title) {
// TODO: HTML escape
return `<i class="close icon"></i>
` + (title ? `<div class="${this.settings.headerClass}">${title}</div>
` : '') + `<div class="${this.settings.contentClass} content atk-dialog-content">
Expand Down Expand Up @@ -1897,7 +1899,7 @@ class AtkJsSortablePlugin extends _AbstractPlugin__WEBPACK_IMPORTED_MODULE_6__["
return url;
}
injectStyles(style) {
external_jquery__WEBPACK_IMPORTED_MODULE_4___default()('head').append('<style>' + style + '</style>');
external_jquery__WEBPACK_IMPORTED_MODULE_4___default()('head').append('<style>' + style + '</style>'); // TODO: prevent HTML injection
}
}
AtkJsSortablePlugin.DEFAULTS = {
Expand Down Expand Up @@ -2713,12 +2715,13 @@ class ApiService {
const m = external_jquery__WEBPACK_IMPORTED_MODULE_2___default()('<div>').appendTo('body').addClass('ui scrolling modal').css('padding', '1em').html(contentHtml);
m.data('needRemove', true).modal().modal('show');
}
getErrorHtml(titleHtml, messageHtml) {
getErrorHtml(title, message) {
// TODO: HTML escape
return `<div class="ui negative icon message" style="margin: 0px;">
<i class="warning sign icon"></i>
<div class="content">
<div class="header">${titleHtml}</div>
<div>${messageHtml}</div>
<div class="header">${title}</div>
<div>${message}</div>
</div>
</div>`;
}
Expand Down Expand Up @@ -3234,7 +3237,8 @@ class ModalService {
}
}
getLoaderHtml(loaderText) {
return '<div class="ui active inverted dimmer">' + '<div class="ui text loader">' + loaderText + '</div>' + '</div>';
return '<div class="ui active inverted dimmer">' + '<div class="ui text loader">' + loaderText + '</div>' // TODO: HTML escape
+ '</div>';
}
}
/* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = (Object.freeze(new ModalService()));
Expand Down
2 changes: 1 addition & 1 deletion public/js/atkjs-ui.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion public/js/atkjs-ui.min.js.map

Large diffs are not rendered by default.

0 comments on commit 52e6ac9

Please sign in to comment.