Add flatpak support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jmercouris
reviewed
Jul 4, 2023
nfiles.lisp
Outdated
| (defmethod resolve ((profile profile) (file config-file)) | ||
| (maybe-xdg #'uiop:xdg-config-home (call-next-method))) | ||
| #-flatpak |
There was a problem hiding this comment.
You could just move this branch to line 303 above instead, that way you don't have to put it everywhere.
There was a problem hiding this comment.
See how nfiles.lisp now looks like. Is this what you had in mind?
There was a problem hiding this comment.
Yet another alternative: put them all inside a single progn and only use feature expression on this progn. That still counts as top level form, while being much easier to include/exclude 😃
|
Looks good to me, please squash before merging. Thanks! |
|
Perfect, thank you. |
aadcg
force-pushed
the
add-flatpak-support
branch
from
13e36bf
to
3626e8d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses atlas-engineer/nyxt#3044.