[Jira] Fix get method data retrieval failures when advanced mode is on

[gibsramen]

Relevant to #1137, #501

Background

A couple methods in Jira use chained method calls to retrieve data immediately after querying the API. For example, the get_issue_link_types method returns the data with the following line:

atlassian-python-api/atlassian/jira.py

Line 3184 in e9520ab

return (self.get(url) or {}).get("issueLinkTypes")

With advanced mode off, this is no problem because the first .get call returns a dictionary upon which the next .get operates. However, with advanced mode on, the result of the first .get is a requests.Response object. This class has no .get method, leading to the following error:

AttributeError: 'Response' object has no attribute 'get'

Changes

This PR adds a helper method in the underlying AtlassianRestAPI object, _get_response_content to help with retrieving API data regardless of the status of advanced_mode. This method takes the same arguments as AtlassianRestAPI.get with one additional requirement: fields. This is a list of tuples of the format (<field name>, <default value>). These fields are used for getting the data out of the API JSON. Note that including a default value is optional.

You can pass in multiple fields and they will be sequentially queried. E.g. if the response looked like the following:

{
    "field1": {
        "field2": {
            "field3": "A"
        }
    }
}

you could query it with self._get_response_content(url, fields=[("field1",), ("field2",), ("field3",)]) and return "A"

The following methods have been updated to use this new method:

• get_issue_link_types
• get_issue_labels
• get_issue_status
• get_issue_status_id
• get_project_actors_for_role_project
• get_status_id_from_name
• get_issue_link_types
• get_all_permissionschemes
• get_issue_security_schemes
• get_issue_security_scheme

[codecov]

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 34.35%. Comparing base (e9520ab) to head (41075ac).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
atlassian/jira.py	0.00%	12 Missing ⚠️
atlassian/rest_client.py	7.69%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   34.40%   34.35%   -0.05%     
==========================================
  Files          46       46              
  Lines        8606     8621      +15     
  Branches     1604     1608       +4     
==========================================
+ Hits         2961     2962       +1     
- Misses       5520     5534      +14     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.