-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update most of Compiled documentation to reflect current recommendations #1688
Conversation
…'Deprecated features' section
- move template literals to deprecated page - discourage dynamic styles - move outdated composition syntax to deprecated page
* Deprecate styled and ClassNames * Merge CSS page into CSS prop * Update cssMap to use flat `@media` query syntax, not the nested one that DST will remove support for * Move details about the `jsx-pragma` ESLint rule to the "JSX pragma" section of the Installation page
|
✅ Deploy Preview for compiled-css-in-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
``` | ||
|
||
Read [composition](/composition) for more information around composing styles together. | ||
The contents of this page have been merged into the [css prop](/api-css-prop) documentation. Check it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping this page just so people don't get 404s
couldn't find an easy way to set up some kind of redirect, or maybe there's a better way you can think of?
@@ -1,4 +1,4 @@ | |||
/** @jsxAutomaticRuntime @compiled/react */ | |||
/** @jsxImportSource @compiled/react */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a typo that hadn't been noticed for years haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good from here!
|
||
Create a component that styles a JSX element which comes with built-in behavior such as `ref` and `as` prop support. | ||
|
||
<StyledObj /> | ||
|
||
> **Tagged template expressions** <br /> Tagged template expressions are supported but call expression syntax is preferred. | ||
> **Tagged template expressions** <br /> Tagged template expressions are supported but using object styles is preferred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of surprised how much stuff changed over time.
Follow-up to #1687
Update most of the Compiled documentation so that it matches our current recommendations (e.g. object styles > template strings) and the UI Styling Standard recommendations.
Sections changed as part of this PR:
See the individual commits for a detailed breakdown of changes - reading commit-by commit will likely be far easier to review. Summary of most notable commits:
@media
query syntax, not the nested one that DST will remove support forjsx-pragma
ESLint rule to the "JSX pragma" section of the Installation page