Fix border-inline-start and border-inline-end not having any valid ordering #1756
Conversation
dddlr
requested review from
JakeLane,
pancaspe87,
liamqma and
zesmith2
as code owners
🦋 Changeset detectedLatest commit: 07385fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
dddlr
force-pushed
the
bug/border-inline-start-sorting
branch
from
06f59c3 to
99e4aec
Compare
package.json
Outdated
| @@ -158,5 +158,6 @@ | |||
| "react" | |||
| ] | |||
| } | |||
| ] | |||
| ], | |||
| "packageManager": "yarn@1.22.21+sha256.dbed5b7e10c552ba0e1a545c948d5473bc6c5a28ce22a8fd27e493e3e5eb6370" | |||
There was a problem hiding this comment.
What's this about?
There was a problem hiding this comment.
gahhh yarn keeps adding that
There was a problem hiding this comment.
we're supposed to specify what version of yarn the repo should use through packageManager
i never got the chance to set this up properly, so it keeps trying to add it whenever i run yarn install
maybe i should just set it up 🤔 hold on
There was a problem hiding this comment.
hmm looks a bit complicated, something for another day...
There was a problem hiding this comment.
Yeah no clue 🫡
What is this change?
Fix how
border-inline-startandborder-inline-enddoes not have any valid ordering in theshorthand-property-sortingESLint rule.Follow up to #1749
Why are we making this change?
Fix one more false positive that slipped through the cracks.
PR checklist
Don't delete me!
I have...
website/