This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Implement naming conventions in HTML grammar #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview of the changes with Atom's default syntax themes:
Code snippet: <!doctype html>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html lang="en">
<head>
<title>Origami</title>
<meta charset="utf-8">
<link rel="stylesheet" href="platypus.css">
</head>
<body>
<a href="/">
<img src="Anya.png"/>
Lighthouse
</a>
<!-- Memory -->
<form id="rocket">
<input type="password"/>
<button type="submit" class="paper rabbit">
<span>Launch</span>
</button>
</form>
</body>
</html> |
This was referenced Jan 12, 2021
chbk
force-pushed
the
scopes
branch
2 times, most recently
from
aea56e3
to
0903e2c
Compare
This was referenced Jan 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a rewrite of the Tree-sitter grammar to implement naming conventions for syntax scopes.
Benefits
Possible Drawbacks
Some new scopes to be added to themes. The changes aim to facilitate theme development, filling the template is enough to ensure coherent highlighting across languages, instead of painfully creating styling rules for every language separately.
Applicable Issues
Related Pull Requests