Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Fix Tree-Sitter JavaScript highlighting for JSX file #104

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Fix Tree-Sitter JavaScript highlighting for JSX file #104

merged 1 commit into from
Nov 14, 2018

Conversation

ryanolsonx
Copy link
Contributor

This should also apply to standard JavaScript files, but specifically,
JSX syntax highlighting has been struggling.

Description of the Change

As noted in #100, there's a lot of highlighting missing when Tree-Sitter is enabled for JavaScript. The focus of this PR is to address many of those changes and provide much needed color. It doesn't fix everything perfectly. In atom/language-javascript, there's an issue (atom/language-javascript#618) that covers adding highlighting back for language keywords (such as this and super).

Before

46153660-356c1400-c239-11e8-91ef-27a6720e3df4

After

screen shot 2018-11-02 at 8 43 24 pm

Alternate Designs

None.

Benefits

JavaScript highlighting is improved.

Possible Drawbacks

None.

Applicable Issues

#100

This should also apply to standard JavaScript files, but specifically, 
JSX syntax highlighting has been struggling.
@ryanolsonx
Copy link
Contributor Author

@simurai Any thoughts on this?

@simurai
Copy link
Contributor

simurai commented Nov 14, 2018

As noted in #100, there's a lot of highlighting missing when Tree-Sitter is enabled for JavaScript.

I think there is still some work in progress getting the Tree-sitter syntax highlighting more in sync with Textmate's. But we can still merge this now since it looks already much better.

@ryanolsonx Thanks.. 🙇

@simurai simurai merged commit 502d3f3 into atom:master Nov 14, 2018
@simurai simurai mentioned this pull request Nov 14, 2018
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants