This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Native std::optional (from C++17) #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
native-optional
branch
from
e1636ad to
d424a01
Compare
aminya
force-pushed
the
native-optional
branch
from
d424a01 to
b0702ea
Compare
usleep is specific to Linux
The literals should be added for all the elements not just the first one 1) Fixes error C2022: '55357': too big for character or similar errors 2) fixes the tests
Fixes the failing test that convert to/from u8
This reverts commit 833f7dd. Update README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #82.
Only the last commit is the change of this PR:
Description of the change
This replaces the old manual optional class with the native optional class from C++17 (std::optional)
Verifications
All the tests pass
Release Notes