Fix spaces-to-tabs and tabs-to-spaces to use "tab stops" correctly#67
Fix spaces-to-tabs and tabs-to-spaces to use "tab stops" correctly#67giseburt wants to merge 3 commits intoatom:masterfrom
Conversation
|
Btw, this should now match the behavior of the equivalent commands in TextMate. |
|
Sorry for the delay in reviewing this, @giseburt. @nathansobo You reviewed and worked on similar PRs in Atom core, I think (atom/atom#5658, atom/atom#7563, atom/atom#7602) -- when you get a chance, could you take a look at this one as well? 🙏 Also, I noticed that the PR no longer merges without conflicts. Probably minor things to resolve compared to master -- could you update the PR so that it is mergeable, @giseburt? |
|
I'm confused about the changes to the specs regarding the various settings... many of them seem to be testing the config system rather than anything particular to this package. It would be easier to review this if it focused exclusively on tab to whitespace conversion. |
There was a problem hiding this comment.
Not sure why you added this...
With these corrections, the tabs-to-spaces and spaces-to-tabs conversions match the layout of the core editor display, as well as are capable of going round-trip (spaces -> tabs -> spaces) without losing the visual positions of the non-whitespace characters.
I also had to beef up the specs a little, since they would fail on non-Travis (IOW, machines that had Atom installed and had some personalization) machines. It is just basic hygiene of setting parameters back to expected values before starting the next test. (More could probably be done, but what I have now appears to be fairly robust.)
I changed the specs to reflect the new expected behavior.
No documentation changes are necessary.
Animation of the corrected behavior:
