Feat: Add command input to Chart tab #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ConsoleInput component at bottom of Chart view for quick command sending without switching to Console tab. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SJ7F
reviewed
Nov 27, 2025
Contributor
SJ7F
left a comment
SJ7F
left a comment
There was a problem hiding this comment.
I have tested this, and while it does successfully send data over serial, it does not add the outgoing messages to the serial log. Take a look at how this is implemented in src/components/SerialConsole.tsx
Messages sent from Chart tab ConsoleInput now properly logged to console store, matching SerialConsole behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SJ7F
approved these changes
Nov 27, 2025
Contributor
SJ7F
left a comment
SJ7F
left a comment
There was a problem hiding this comment.
Seems to work as expected from my testing.
It would be better from a code quality standpoint to call the same handleSendMessage function instead of duplicating it, but this works I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code