-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement feedback #28
base: staging
Are you sure you want to change the base?
Conversation
server/controllers/RoleController.js
Outdated
@@ -91,9 +91,10 @@ class RoleController { | |||
} | |||
return roles | |||
.destroy() | |||
.then(() => res.send(200)); | |||
.then(() => res.send(200)) | |||
.catch(error => res.status(500).json({ message: 'Server Error', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 95 exceeds the maximum line length of 80 max-len
} | ||
}); | ||
}) | ||
.catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 355 exceeds the maximum line length of 80 max-len
} | ||
return res.status(200).json(userInfo(user)); | ||
}) | ||
.catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 223 exceeds the maximum line length of 80 max-len
@@ -136,7 +136,7 @@ class UserController { | |||
return res.status(401).json({ message: 'Wrong Password' }); | |||
} | |||
}) | |||
.catch(error => res.status(400).json(error)); | |||
.catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 139 exceeds the maximum line length of 80 max-len
@@ -29,7 +29,7 @@ class RoleController { | |||
static list(req, res) { | |||
return Role.all() | |||
.then(roles => res.status(200).json(roles)) | |||
.catch(error => res.status(400).json(error)); | |||
.catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 32 exceeds the maximum line length of 80 max-len
.catch(error => res.status(400).json(error)); | ||
}); | ||
.catch(error => res.status(500).json({ message: 'An Errorr Ocurred', error })); | ||
}).catch(error => res.status(500).json({ message: 'An Errorr Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 171 exceeds the maximum line length of 80 max-len
return document.destroy() | ||
.then(() => res.send(200)) | ||
.catch(error => res.status(400).json(error)); | ||
}); | ||
.catch(error => res.status(500).json({ message: 'An Errorr Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 170 exceeds the maximum line length of 80 max-len
@@ -129,7 +129,7 @@ class DocumentController { | |||
}); | |||
} | |||
return res.status(200).json(document); | |||
}).catch(error => res.status(400).json(error)); | |||
}).catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 132 exceeds the maximum line length of 80 max-len
.catch(error => res.status(400).json(error)); | ||
}); | ||
.catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); | ||
}).catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 171 exceeds the maximum line length of 80 max-len
return document.destroy() | ||
.then(() => res.send(200)) | ||
.catch(error => res.status(400).json(error)); | ||
}); | ||
.catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 170 exceeds the maximum line length of 80 max-len
return document | ||
.update(req.body) | ||
.then(() => res.status(200).json(document)) | ||
.catch(error => res.status(400).json(error)); | ||
}); | ||
}).catch(error => res.status(500).json({ message: 'An Error Ocurred', error })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 152 exceeds the maximum line length of 80 max-len
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
N/A
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
N/A
Screenshots (if appropriate):
N/A
Questions:
N/A