Skip to content

feat: Gno LC with diff from 07-tendermint #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clockworkgr wants to merge 11 commits into from
Closed

feat: Gno LC with diff from 07-tendermint #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6118851
feat: commit 07-tendermint-client
clockworkgr Oct 15, 2025
094bc22
feat: gno LC commit
clockworkgr Oct 15, 2025
96408cf
feat: Complete verification
clockworkgr Oct 15, 2025
ee954a7
chore: wire up module and update comments
clockworkgr Oct 16, 2025
53d830a
chore: Re-added and adjusted tests
clockworkgr Oct 16, 2025
54d1f00
chore: fix LC module keeper route
clockworkgr Oct 16, 2025
fbcb140
chore: linting
clockworkgr Nov 5, 2025
b2497d3
fix: Fix public key encoding handling
clockworkgr Nov 27, 2025
85fbb78
chore: Remove broken tests
clockworkgr Jan 13, 2026
cf25ae7
chore: Add new tests
clockworkgr Jan 13, 2026
29a6b62
Merge remote-tracking branch 'upstream/main' into feat/gno-lc-with-diff
clockworkgr Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ ldflags := $(strip $(ldflags))
BUILD_FLAGS := -tags "$(build_tags)" -ldflags '$(ldflags)'
# check for nostrip option
ifeq (,$(findstring nostrip,$(ATOMONE_BUILD_OPTIONS)))
BUILD_FLAGS += -trimpath
# BUILD_FLAGS += -trimpath
endif

###############################################################################
Expand Down
3 changes: 3 additions & 0 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"github.com/gorilla/mux"
"github.com/spf13/cast"

// Force registration of gno proto types
_ "github.com/atomone-hub/atomone/modules/10-gno"

abci "github.com/cometbft/cometbft/abci/types"

dbm "github.com/cosmos/cosmos-db"
Expand All @@ -18,12 +21,12 @@
ibckeeper "github.com/cosmos/ibc-go/v10/modules/core/keeper"
ibctesting "github.com/cosmos/ibc-go/v10/testing"

autocliv1 "cosmossdk.io/api/cosmos/autocli/v1"

Check failure on line 24 in app/app.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/api/cosmos/autocli/v1 (imported by github.com/atomone-hub/atomone/app); to add:
reflectionv1 "cosmossdk.io/api/cosmos/reflection/v1"

Check failure on line 25 in app/app.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/api/cosmos/reflection/v1 (imported by github.com/atomone-hub/atomone/app); to add:
"cosmossdk.io/client/v2/autocli"

Check failure on line 26 in app/app.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/client/v2/autocli (imported by github.com/atomone-hub/atomone/app); to add:
clienthelpers "cosmossdk.io/client/v2/helpers"

Check failure on line 27 in app/app.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/client/v2/helpers (imported by github.com/atomone-hub/atomone/app); to add:
"cosmossdk.io/core/appmodule"

Check failure on line 28 in app/app.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/core/appmodule (imported by github.com/atomone-hub/atomone/app); to add:
"cosmossdk.io/log"

Check failure on line 29 in app/app.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/log (imported by github.com/atomone-hub/atomone/app); to add:
"cosmossdk.io/x/tx/signing"
upgradetypes "cosmossdk.io/x/upgrade/types"

Expand Down
20 changes: 13 additions & 7 deletions app/keepers/keepers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
stakingkeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"

ibcgno "github.com/atomone-hub/atomone/modules/10-gno"
coredaoskeeper "github.com/atomone-hub/atomone/x/coredaos/keeper"
coredaostypes "github.com/atomone-hub/atomone/x/coredaos/types"
dynamicfeekeeper "github.com/atomone-hub/atomone/x/dynamicfee/keeper"
Expand Down Expand Up @@ -101,6 +102,7 @@
ICAModule ica.AppModule
TransferModule transfer.AppModule
TMClientModule ibctm.AppModule
GnoModule ibcgno.AppModule
}

func NewAppKeeper(
Expand Down Expand Up @@ -371,10 +373,14 @@
storeProvider := clientKeeper.GetStoreProvider()

tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider)

gnoLightClientModule := ibcgno.NewLightClientModule(appCodec, storeProvider)

appKeepers.IBCKeeper.ClientKeeper.AddRoute(ibctm.ModuleName, &tmLightClientModule)
appKeepers.IBCKeeper.ClientKeeper.AddRoute(ibcgno.ModuleName, &gnoLightClientModule)

appKeepers.TMClientModule = ibctm.NewAppModule(tmLightClientModule)

appKeepers.GnoModule = ibcgno.NewAppModule(gnoLightClientModule)
return appKeepers
}

Expand All @@ -393,12 +399,12 @@

//nolint: staticcheck // SA1019: moduletypes.ParamKeyTable is deprecated
paramsKeeper.Subspace(authtypes.ModuleName).WithKeyTable(authtypes.ParamKeyTable())
paramsKeeper.Subspace(stakingtypes.ModuleName).WithKeyTable(stakingtypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(banktypes.ModuleName).WithKeyTable(banktypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(minttypes.ModuleName).WithKeyTable(minttypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(distrtypes.ModuleName).WithKeyTable(distrtypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(slashingtypes.ModuleName).WithKeyTable(slashingtypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(govtypes.ModuleName).WithKeyTable(govv1.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(stakingtypes.ModuleName).WithKeyTable(stakingtypes.ParamKeyTable())

Check failure on line 402 in app/keepers/keepers.go

View workflow job for this annotation

GitHub Actions / Analyze 

SA1019: stakingtypes.ParamKeyTable is deprecated: now params can be accessed on key `0x51` on the staking store. ParamTable for staking module (staticcheck)
paramsKeeper.Subspace(banktypes.ModuleName).WithKeyTable(banktypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(minttypes.ModuleName).WithKeyTable(minttypes.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(distrtypes.ModuleName).WithKeyTable(distrtypes.ParamKeyTable())

Check failure on line 405 in app/keepers/keepers.go

View workflow job for this annotation

GitHub Actions / Analyze 

SA1019: distrtypes.ParamKeyTable is deprecated: ParamKeyTable returns the parameter key table. (staticcheck)
paramsKeeper.Subspace(slashingtypes.ModuleName).WithKeyTable(slashingtypes.ParamKeyTable())

Check failure on line 406 in app/keepers/keepers.go

View workflow job for this annotation

GitHub Actions / Analyze 

SA1019: slashingtypes.ParamKeyTable is deprecated: ParamKeyTable for slashing module (staticcheck)
paramsKeeper.Subspace(govtypes.ModuleName).WithKeyTable(govv1.ParamKeyTable()) //nolint:staticcheck // SA1019
paramsKeeper.Subspace(ibctransfertypes.ModuleName)
paramsKeeper.Subspace(ibcexported.ModuleName)
paramsKeeper.Subspace(icahosttypes.SubModuleName)
Expand Down
1 change: 1 addition & 0 deletions app/modules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
ibc "github.com/cosmos/ibc-go/v10/modules/core"
ibcexported "github.com/cosmos/ibc-go/v10/modules/core/exported"

"cosmossdk.io/x/evidence"

Check failure on line 11 in app/modules.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/x/evidence (imported by github.com/atomone-hub/atomone/app); to add:
evidencetypes "cosmossdk.io/x/evidence/types"

Check failure on line 12 in app/modules.go

View workflow job for this annotation

GitHub Actions / test-sim-nondeterminism 

missing go.sum entry for module providing package cosmossdk.io/x/evidence/types (imported by github.com/atomone-hub/atomone/app); to add:
"cosmossdk.io/x/feegrant"
feegrantmodule "cosmossdk.io/x/feegrant/module"
"cosmossdk.io/x/upgrade"
Expand Down Expand Up @@ -120,6 +120,7 @@
app.TransferModule,
app.ICAModule,
app.TMClientModule,
app.GnoModule,
}
}

Expand Down
1 change: 1 addition & 0 deletions docs/static/openapi.json
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 19 additions & 6 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ require (
github.com/cometbft/cometbft v0.38.20
github.com/cosmos/cosmos-db v1.1.1
github.com/cosmos/cosmos-proto v1.0.0-beta.5
github.com/cosmos/cosmos-sdk v0.53.0
github.com/cosmos/cosmos-sdk v0.53.4
github.com/cosmos/go-bip39 v1.0.0
github.com/cosmos/gogoproto v1.7.2
github.com/cosmos/ibc-go/v10 v10.2.0
Expand All @@ -41,7 +41,7 @@ require (
github.com/spf13/cobra v1.9.1
github.com/spf13/pflag v1.0.6
github.com/spf13/viper v1.20.1
github.com/stretchr/testify v1.10.0
github.com/stretchr/testify v1.11.1
golang.org/x/sync v0.16.0
google.golang.org/genproto/googleapis/api v0.0.0-20250707201910-8d1bb00bc6a7
google.golang.org/grpc v1.75.0
Expand All @@ -62,7 +62,7 @@ require (
filippo.io/edwards25519 v1.1.0 // indirect
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
github.com/99designs/keyring v1.2.2 // indirect
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect
github.com/Azure/go-ansiterm v0.0.0-20250102033503-faa5f7b0171c // indirect
github.com/DataDog/datadog-go v4.8.3+incompatible // indirect
github.com/DataDog/zstd v1.5.7 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.29.0 // indirect
Expand Down Expand Up @@ -114,7 +114,7 @@ require (
github.com/cosmos/ledger-cosmos-go v0.16.0 // indirect
github.com/creachadair/atomicfile v0.3.1 // indirect
github.com/creachadair/tomledit v0.0.24 // indirect
github.com/danieljoos/wincred v1.2.1 // indirect
github.com/danieljoos/wincred v1.2.3 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
github.com/desertbit/timer v1.0.1 // indirect
Expand All @@ -134,6 +134,7 @@ require (
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fsnotify/fsnotify v1.9.0 // indirect
github.com/getsentry/sentry-go v0.35.0 // indirect
github.com/gnolang/gno v0.0.0-20251010155040-3f1cc0962a5f
github.com/go-jose/go-jose/v4 v4.1.1 // indirect
github.com/go-kit/kit v0.13.0 // indirect
github.com/go-kit/log v0.2.1 // indirect
Expand Down Expand Up @@ -175,7 +176,6 @@ require (
github.com/holiman/uint256 v1.3.2 // indirect
github.com/huandu/skiplist v1.2.1 // indirect
github.com/iancoleman/strcase v0.3.0 // indirect
github.com/imdario/mergo v0.3.12 // indirect
github.com/improbable-eng/grpc-web v0.15.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/jmhodges/levigo v1.0.0 // indirect
Expand All @@ -197,7 +197,7 @@ require (
github.com/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09a // indirect
github.com/oklog/run v1.1.0 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.1.0-rc2 // indirect
github.com/opencontainers/image-spec v1.1.1 // indirect
github.com/opencontainers/runc v1.1.12 // indirect
github.com/pelletier/go-toml/v2 v2.2.4 // indirect
github.com/petermattis/goid v0.0.0-20240813172612-4fcff4a6cae7 // indirect
Expand Down Expand Up @@ -279,3 +279,16 @@ replace (
// replace broken cosmos-sdk dep
nhooyr.io/websocket => github.com/coder/websocket v1.8.6
)

tool (
github.com/bufbuild/buf/cmd/buf
github.com/cosmos/cosmos-proto/cmd/protoc-gen-go-pulsar
github.com/cosmos/gogoproto/protoc-gen-gocosmos
github.com/cosmos/gogoproto/protoc-gen-gogo
github.com/golangci/golangci-lint/cmd/golangci-lint
github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2
golang.org/x/tools/cmd/goimports
google.golang.org/grpc/cmd/protoc-gen-go-grpc
google.golang.org/protobuf/cmd/protoc-gen-go
)
Loading
Loading