fix(x/gov): Added missing flags to cli query gov commands #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-deposit and constitution
giuliostramondo
requested review from
giunatale,
jaekwon and
tbruyelle
as code owners
giunatale
approved these changes
Nov 20, 2025
tbruyelle
approved these changes
Nov 20, 2025
julienrbrt
approved these changes
Nov 21, 2025
Collaborator
|
Are we waiting for something specific before merging this PR ? |
Collaborator
|
changes to x/gov are useless on the atomone module since we are migrating. we should not merge but verify that this is also addressed when doing the migration |
Collaborator
|
It should have been added :) |
Collaborator
|
NOTE: this PR won't be merged due to the migration to the Waiting on #248 to be merged to close this since it should be included between atomone-hub/cosmos-sdk#17 and #248. |
Collaborator
|
Don't we want this for V3 however? |
Collaborator
if people don't complain about it, I'd say no. We save ourselves from having to do a release that is client-side only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing flags to cli query gov commands min-deposit min-initial-deposit and constitution
fixes #244