feat(gov): add governors #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
giuliostramondo,
jaekwon and
tbruyelle
as code owners
tbruyelle
requested changes
Dec 19, 2025
julienrbrt
approved these changes
Dec 19, 2025
Collaborator
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
utACK!
General question, will we keep x/gov and x/atomone-gov always 1-1?
We could have went the way of not supporting those new messages in the wrapper, and that the wrapper would only be used for backward compat of tooling.
Collaborator
Author
probably not, we might want the two to differ slightly moving forward. For not I think it's good as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add governors to atomone:
Based on the work done in #73
Enabled by atomone-hub/cosmos-sdk#36