fix(dynamicfee): add params.ValidateBasic to types\MsgUpdateParams
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
giuliostramondo,
jaekwon and
tbruyelle
as code owners
julienrbrt
approved these changes
Jan 7, 2026
Collaborator
|
I am working on issue #122 . I have opened a PR (atomone-hub/cosmos-sdk#48) to move this module on the sdk. |
Collaborator
Author
|
you are completely right @giuliostramondo, my bad. Lmk when you push this change to that PR so I can close this one, or you can go ahead and do it yourself. |
Collaborator
|
@giunatale Can we have a test on this ? |
Pantani
approved these changes
Jan 13, 2026
Collaborator
|
This PR should be closed in favor of atomone-hub/cosmos-sdk#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform
msg.Params.ValidateBasic()whenmsg.ValidateBasic()is invoked forMsgUpdateParams