chore(gov): panic on errors instead of suppressing them #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
giuliostramondo,
jaekwon and
tbruyelle
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For functions like
RefundAndDeleteDepositsandDeleteAndBurnDepositsbefore migrating to the wrapper errors would trigger apanic, while now they are just suppressed which is not ideal. Therefore I've changed the behavior so now it panics.Moreover, since for collections related-code the same was done I've also added panics there but tbh it should matter less here since errors are generally related only to encoding which can't really be the case here.