Add file:native_name_encoding/0 #1807
Merged
+68
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
reviewed
Aug 20, 2025
src/libAtomVM/nifs.c
Outdated
|
|
||
| static bool env_equals(const char *env_var, const char *value) | ||
| { | ||
| const char *env_value = getenv(env_var); |
There was a problem hiding this comment.
POSIX says getenv is not thread safe. You need to hold global->env_spinlock.
src/libAtomVM/nifs.c
Outdated
| UNUSED(ctx) | ||
| UNUSED(argc) | ||
| UNUSED(argv) | ||
| if (env_equals("LC_ALL", "UTF-8") || env_equals("LC_CTYPE", "UTF-8") || env_equals("LANG", "UTF-8")) { |
There was a problem hiding this comment.
I am confused by this implementation. We could simply always return utf8, couldn't we? The most important part here is the documentation of the function.
mat-hek
changed the title
bettio
requested changes
Sep 5, 2025
mat-hek
force-pushed
the
mf/file-native-name-encoding
branch
2 times, most recently
from
91e19cf to
479e989
Compare
|
@bettio seems like some unrelated tests are timing out/failing on the CI |
bettio
approved these changes
Sep 19, 2025
That's ok, I will re-run CI before merging. |
bettio
requested changes
Sep 19, 2025
| % SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later | ||
| % | ||
|
|
||
| -module(test_file_native_name_encoding). |
There was a problem hiding this comment.
Let's rename to test_file so we can consistent with other tests in tests/libs/estdlib/tests.erl.
mat-hek
force-pushed
the
mf/file-native-name-encoding
branch
2 times, most recently
from
fadedca to
3893e7e
Compare
Signed-off-by: Mateusz Front <mateusz.front@swmansion.com>
mat-hek
force-pushed
the
mf/file-native-name-encoding
branch
from
3893e7e to
c63a2ff
Compare
bettio
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later