-
Notifications
You must be signed in to change notification settings - Fork 162
updated references to include URLs #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideStandardized and enriched citation entries in docstrings by appending direct arXiv URLs and unifying the reference style across all methods and class definitions without touching functional code. Class diagram for updated docstring references in ConditionalFlowMatcher and subclassesclassDiagram
class ConditionalFlowMatcher {
+compute_mu_t(x0, x1, t)
+compute_sigma_t(t)
+sample_xt(x0, x1, t, epsilon)
+compute_conditional_flow(x0, x1, t, xt)
+sample_location_and_conditional_flow(x0, x1, t, return_noise)
+compute_lambda(t)
"References updated with arXiv URLs"
}
class ExactOptimalTransportConditionalFlowMatcher {
+sample_location_and_conditional_flow(x0, x1, t, return_noise)
+guided_sample_location_and_conditional_flow(x0, x1, y0, y1, t, return_noise)
"References updated with arXiv URLs"
}
class TargetConditionalFlowMatcher {
+compute_mu_t(x0, x1, t)
+compute_sigma_t(t)
+compute_conditional_flow(x0, x1, t, xt)
"References updated with arXiv URLs"
}
class SchrodingerBridgeConditionalFlowMatcher {
+compute_sigma_t(t)
+compute_conditional_flow(x0, x1, t, xt)
+sample_location_and_conditional_flow(x0, x1, t, return_noise)
+guided_sample_location_and_conditional_flow(x0, x1, y0, y1, t, return_noise)
"References updated with arXiv URLs"
}
class VariancePreservingConditionalFlowMatcher {
+compute_mu_t(x0, x1, t)
+compute_conditional_flow(x0, x1, t, xt)
"References updated with arXiv URLs"
}
ExactOptimalTransportConditionalFlowMatcher --|> ConditionalFlowMatcher
TargetConditionalFlowMatcher --|> ConditionalFlowMatcher
SchrodingerBridgeConditionalFlowMatcher --|> ConditionalFlowMatcher
VariancePreservingConditionalFlowMatcher --|> ConditionalFlowMatcher
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing repeated reference strings (e.g. URLs and author names) in a single constants module or shared variable to avoid duplication and simplify future updates.
- Double-check that citation numbering and formatting remain consistent across all classes and methods after adding the URLs to ensure readers aren’t confused by mismatched labels.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing repeated reference strings (e.g. URLs and author names) in a single constants module or shared variable to avoid duplication and simplify future updates.
- Double-check that citation numbering and formatting remain consistent across all classes and methods after adding the URLs to ensure readers aren’t confused by mismatched labels.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
What does this PR do?
I tried to bring the references in a more homogenous shape and also added them in the class docstrings. This can make it easier for readers to look-up the underlying science to the implementation.
No breaking changes.
Before submitting
pytest
command?pre-commit run -a
command?All edits were made on github.com
Did you have fun?
yes!
Summary by Sourcery
Enhancements: