Update resources #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @atroche, Can you accept this changes for add Update options? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @atroche! Great library and very pleasant to use. Unfortunately it didn't have the update function, so I decided to add one by myself (for now just updating singular resource, but happy to add batch version as well).
I wasn't entirely sure what to do with the
src/clj_zendesk/apps.cljfile, so just left it for now.lein checkcomplains about this file in a few places (mostly usage of no longer existing vars). Perhaps I can make some alterations in it too.Let me know if I can help!