Add methods for the USB Start Of Frame interrupt #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops! I forgot to add the change to thumbv7, so have updated the PR. |
|
@sajattack, I haven't worked with USB at all. Do you want to take a look at this? |
|
Me neither tbh. @twitchyliquid64 ? |
twitchyliquid64
approved these changes
Jul 31, 2021
jbeaurivage
reviewed
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using #398 a bit, I found that checking the SOF flag in
poll()was problematic, because from the outside it's not clear whether or not the SOF flag was set.This functionality is helpful in the context of USB classes which are always accessed in the USB ISR (working around #397). If the host isn't read/writing to the endpoint, but the device has info it wants to send, then somehow execution needs to get back in to the USB ISR.
Since the PR is so small, and the original one hasn't been updated in a while, I've made a new PR. If that's problematic, I'd be happy to re-do this as a PR against https://github.com/henrikssn/atsamd/tree/usb-sof