Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make traits public in the CAN module #778

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

maximeborges
Copy link
Contributor

Summary

Making OwnedPeripheral, RxPin, TxPin public and sealed so they can be used to make abstraction layers in your own application.

Checklist

  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

Note

The crate changelogs should no longer be manually updated! Changelogs are now automatically generated. Instead:

  • If your PR is contained to a single crate, or a single feature:
    • Nothing else to do; your PR will likely be squashed down to a single commit.
    • Please consider using conventional commmit phrasing in the PR title.
  • If your PR brings in large, sweeping changes across multiple crates:
    • Organize your commits such that each commit only touches a single crate, or a single feature across multiple crates. Please don't create commits that span multiple features over multiple crates.
    • Use conventional commmits for your commit messages.

@jbeaurivage jbeaurivage force-pushed the bugfix/mcan_pub_trait branch from f4c37e4 to 21ba360 Compare November 10, 2024 04:06
@jbeaurivage jbeaurivage merged commit f91c7aa into atsamd-rs:master Nov 10, 2024
108 checks passed
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
@maximeborges maximeborges deleted the bugfix/mcan_pub_trait branch November 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants