feat(spi): Unlock DMA transfers for SpiBus::transfer_in_place #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unsoundness issues caused by mishandled memory barriers in the
dmac
module.These were causing observable undefined behaviour in the SpiBus::transfer_in_place implementation when trying to use DMA. The implementation was therefore defaulted to using word-by-word transfers in #772.
Now that the bug is fixed, we also unlock DMA in-place transfers for SPI. I've tested the changes and can confirm that there is no longer exhibited unsoundness.
This PR also brings minor refactors to the
dmac
module, and fixes warnings when compiling with thedma
Cargo feature turned off.Checklist
#[allow]
certain lints where reasonable, but ideally justify those with a short comment.