Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npt refresh problems resolved. #1674

Merged
merged 18 commits into from
Jan 21, 2025
Merged

fix: npt refresh problems resolved. #1674

merged 18 commits into from
Jan 21, 2025

Conversation

CurtlyCritchlow
Copy link
Contributor

@CurtlyCritchlow CurtlyCritchlow commented Jan 21, 2025 •
edited
Loading

- What I did

  1. Fixed the text selection issue
  2. Fixed focus node being called after it is disposed
  3. Fixed text field not showing correctly.
  4. "@" automatically added to atsign fields.
  5. Fixed error message being cut off in the UI.
  6. Settings List items reorganised
  7. refresh buttons removed from profiles and popup menu item
  8. Sync progress listener added to update ui when sync completes and profile list is empty.
  9. Localisations updated for new strings.

- How I did it

- How to verify it

- Description for the changelog

@CurtlyCritchlow
fix: text selection offset to text length to prevent text from being …
a000122 
…selected when user enter their atsign.
@CurtlyCritchlow
fix: pinFocusNode moved to prevent being called after being disposed.
bb75706
@CurtlyCritchlow
fix: atsign fields two character issue fixed.
1d8f5a5
@CurtlyCritchlow
fix: padding added to profile relay quick button so the text field la…
a0b06e9 
…bel shows correctly.
@CurtlyCritchlow
fix: atsign fields refactored to ensure @ symbol is prefixed and no w…
794211c 
…hitespace is allowed at the end.
@CurtlyCritchlow
fix: error message is clearly show for relay text fields.
a83619a
@CurtlyCritchlow
fix: settings list items reorganized in order of importance and width…
81e937e 
… of rail increased.
@CurtlyCritchlow
fix: removed the "-" from email and capitalize Back Up You Key in eng…
79df17f 
…lish.
@CurtlyCritchlow
fix: refresh button remove from profile pop up menu item.
a9418f0
@CurtlyCritchlow
fix: refresh button remove from profiles.
a93f2c0
@CurtlyCritchlow
fix: sync progress listener added to refresh profiles when local and …
787e105 
…remote out of sync and profile list is empty.
@CurtlyCritchlow CurtlyCritchlow linked an issue Jan 21, 2025 that may be closed by this pull request
Refreshing a connection that is already connected leads to a bad state #1598
Closed
@CurtlyCritchlow CurtlyCritchlow linked an issue Jan 21, 2025 that may be closed by this pull request
NoPorts Desktop (Refresh button missing if no profiles present) #1615
Closed
@CurtlyCritchlow CurtlyCritchlow marked this pull request as ready for review January 21, 2025 16:16
XavierChanth
XavierChanth requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@XavierChanth XavierChanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments above

XavierChanth
XavierChanth previously approved these changes Jan 21, 2025
View reviewed changes
@CurtlyCritchlow CurtlyCritchlow merged commit 88df6cc into trunk Jan 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CurtlyCritchlow @XavierChanth