feat: Socket authenticators and data transformers #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge response while keeping socket_connector package generic.
docs: improved class doc for SocketAuthenticator
…ble implementations and the changes in the test to uptake it.
…e non-future value because of possible race condition
…etAuthenticator to SocketAuthVerifier
…ds to write to them in order to validate them self
chore: run dart format
refactor: removed dup code
refactor: inlined _onData method and removed it
refactor: inlined _onData method and removed it
style: dan dart format
- made `verbose` an instance variable - made `print`s into `stderr.writeln`s - wrapped `writeln`s in `if (verbose)` blocks
XavierChanth
reviewed
Jan 3, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,11 @@ | |||
| ## 1.1.0 | |||
There was a problem hiding this comment.
Aren't we looking at a major version change? The SocketConnector class had breaking changes
There was a problem hiding this comment.
Updated version and CHANGELOG for 2.0.0 in this commit
XavierChanth
approved these changes
Jan 3, 2024
style: ran dart format
…of the class `Side` fix: fixed the transformer logic
|
@XavierChanth @VJag @cconstab I think this is good to go, please review again - main thing to look at since last time is the additions to the test pack. Still marked as draft because I still need to update the main README before the new version is published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
app-defined way before they will be connected to the other side
transform the data while sending from A to B, and vice versa. Useful for
adding traffic encryption, for example.
- How I did it
- How to verify it