Add support for base-href #64

yowari · 2018-06-12T18:09:44Z

#63
This is my idea of adding support for base-href. To do so:

I extracted the MonacoService from BaseEditor class, I think we should extract more code from this class
I use PlatformLocation to retrieve the baseHref, this should not be used but I didn't found other alternative. I couldn't inject APP_BASE_HREF I got an error:

StaticInjectorError(AppModule)[MonacoService -> InjectionToken appBaseHref]: 
StaticInjectorError(Platform: core)[MonacoService -> InjectionToken appBaseHref]: 
NullInjectorError: No provider for InjectionToken appBaseHref!

filippoboiani · 2019-02-22T14:30:35Z

src/platform/editor/monaco.service.ts

  }

  loadMonaco(): Promise<void> {
    if (!loadedMonaco) {
      loadedMonaco = true;
      loadPromise = new Promise<void>((resolve: any) => {
-        const baseUrl = this.config.baseUrl || '/assets';
+        const baseUrl = this.config.baseUrl || Location.joinWithSlash(this.baseHref, '/assets');


Isn't it enough to replace /assets with ./assets? I got it running on github pages this way.

yowari added 3 commits June 12, 2018 19:40

extract MonacoService from BaseEditor class

3a9f8aa

prepend baseUrl with base-href when no baseUrl config provided

4cfeb43

remove moved variables

8add362

yowari mentioned this pull request Jul 26, 2018

Support base-href option #63

Open

filippoboiani reviewed Feb 22, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for base-href #64

Add support for base-href #64

yowari commented Jun 12, 2018

filippoboiani Feb 22, 2019

Add support for base-href #64

Are you sure you want to change the base?

Add support for base-href #64

Conversation

yowari commented Jun 12, 2018

filippoboiani Feb 22, 2019

Choose a reason for hiding this comment