New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pinctrl driver for imx and meson #262

Draft

dreamliner787-9 wants to merge 126 commits into main from pinmux_rebased

dreamliner787-9 commented Sep 27, 2024 •

edited

Loading

Draft right now because there are still a few things to clean up.

This pull request:

Add pinctrl (also known as pinmux) driver for imx and meson into sDDF.
Add ability to toggle pinctrl initialisation from the meson I2C driver with a macro.
- (To be fixed) There is now a soft dependancy on pinctrl from i2c, if a client wants native pinctrl driver, they will need to supply a DTS.

There are a lot of commits so I think it should be squashed.

Michael-M34 and others added 30 commits

September 16, 2024 16:36


          Skeleton complete + scanning of device tree complete

250d085


          Added some notes about current progress + to-do

ef1805e


          iomuxc: rename pinmux driver to iomuxc, add MaaXBoard DTS and make a …

c537bb2

…working skeleton of static iomuxc driver

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          iomuxc: remove old pinmux example

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          iomuxc: make DTS parsing script take in the SoC name as an argument

b6e3f66

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          iomuxc: removed driver implementation file from driver.c to iomuxc.c

bb1a596

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          iomuxc: general clean up and switch to Microkit 1.4.0

d3e1e8f

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          iomuxc -> pinctrl: rename to match Linux's equivalent

9ec0a7e

Signed-off-by: Bill Nguyen <tiquay03@gmail.com>


          pinctrl: add Makefile snippet for pinctrl driver and move example sys…

80070d5

…tem to example folder

Signed-off-by: Bill Nguyen <tiquay03@gmail.com>


          pinctrl: rename pinmux.system to pinctrl.system

d4e03e3

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add Makefile snippets

1237fb8

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: example system now compiles

f06f257

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: move example system into a subfolder so we can have many pin…

ac10c98

…ctrl examples in the future

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add libmicrokitco submodule to block on timer in pinctrl exa…

01508f6

…mple

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: complete simple pinctrl example, redirecting serial

78fca2c

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: align 4 bytes in python DTS parse script

228b502

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add client interface and proper logging to driver

c141e5b

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: copy echo server example into pinctrl examples directory

2d07955


          pinctrl: pinctrl_driver.mk: compile with debug prints by default for now

13d49a5

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: apply changes to echo server example to have pinmux driver i…

d8981dc

…ntegrated

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: implement proper driver logging

da557b8

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: improve driver logging format

380a42a

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add copyright

b9b20f7

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add copyright

d4a3326

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: remove echo server copy from pinctrl example

7fd05f5

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add query DTS value call to driver and improve client interface

5e1a8f0

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: fix style in DTS python script

aab13d4

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: improve readability of driver code

6ff540a

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add SION bit handling

bbc6087

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: split preprocessing into another loop

e0f3a22

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>

dreamliner787-9 added 21 commits

September 16, 2024 16:57


          pinctrl: update compatibility checking method and add warning for und…

af30861

…ocumented devices for meson

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: patch the example odroidc4 dts to enable the i2c

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: restore meson default initialisation table

e0a24e1

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: default initialise peripherals chip and refactor code

6773c61

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: fix meson makeflie doc phyaddr error

d1c0295

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          i2c: disable pinmux initialisation from meson driver

6cfa1ed

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          i2c: disable gpio MR

d434d98

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add ASFLAGS to driver makefiles

49daf56

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: implement chip select protocol for read registers

c893a7f

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: implement read checking after write for registers

5c31c54

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: break meson memory range definnition into common header file

6f18d74

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: fix odroidc4 dts to enable hdmi device

feeab3a

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: track DTS changes

4c64a79

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: track changes to parsing script

8d12aaf

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: turn off GPIO for any muxed pads in meson

2acc25f

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: make pinctrl_memranges.h standalone

73418c6

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: fix incorrect base register address variable

b10431d

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: fix missing newline in logging

312d979

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: add undocumented HDMI pinmux registers for meson

29ec259

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: apply more stringent error checking for meson dts script

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          i2c: allow pinmux initialisation to be toggled in the makefile

d5127e1

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>

dreamliner787-9 added meson enhancement labels

dreamliner787-9 added 2 commits

September 27, 2024 15:31


          remove pinctrl driver from echo server

df0e3bf

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: style: remove trailling whitespaces

6f6aa73

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>

dreamliner787-9 force-pushed the pinmux_rebased branch from c423521 to 6f6aa73 Compare

September 27, 2024 05:48

dreamliner787-9 added 2 commits

September 27, 2024 15:53


          pinctrl: style: remove trailling whitespaces...

02c058c

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>


          pinctrl: style: run clang-format

e417e8d

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>

Collaborator

Ivan-Velickovic commented Sep 27, 2024

Add ability to toggle pinctrl initialisation from the meson I2C driver with a macro.
There is now a soft dependancy on pinctrl from i2c, if a client wants native pinctrl driver, they will need to supply a DTS.

We should not let the I2C driver do its own pinctrl initialisation - the dependency on the pinctrl driver should be a requirement in my opinion.


          i2c: disable pinmux initialisation

4ed7a11

Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement meson